Skip to content

Skip running a job if the crate/version deleted #11500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2025

Conversation

YohDeadfall
Copy link
Contributor

Fixes #11348.

After diffing in I found only 3 jobs that can fail because of deleted data. The rest should be fine.

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! could you try to write a few regression tests for this too? idk if that is viable for the RenderAndUploadReadme job, but for the other two I think this should be possible.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Jul 3, 2025
@YohDeadfall YohDeadfall force-pushed the skip-job-when-crate-deleted branch from 7204e92 to 8901c38 Compare July 6, 2025 22:22
@YohDeadfall YohDeadfall requested a review from Turbo87 July 8, 2025 19:14
@Turbo87 Turbo87 force-pushed the skip-job-when-crate-deleted branch from 653a3bf to 2cafbef Compare July 13, 2025 15:18
@Turbo87 Turbo87 merged commit a10aa0e into rust-lang:main Jul 13, 2025
10 checks passed
@YohDeadfall YohDeadfall deleted the skip-job-when-crate-deleted branch July 13, 2025 16:20
@YohDeadfall
Copy link
Contributor Author

You could just ask not to use higher order functions and make it simple (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background jobs are infinitely retried if crates are deleted
2 participants